BasisUniversal: Use RGTC compression when available #90170
Conversation
BlueCube3310
force-pushed
the
basisu-rgtc-etc2-rg
branch
from
3915916 to
5f125f3
Compare
BlueCube3310
force-pushed
the
basisu-rgtc-etc2-rg
branch
from
5f125f3 to
01406ff
Compare
There was a problem hiding this comment.
Tested locally, it works as expected. The normal map texture (displayed on the right) seems more yellow but I don't know how close this is to ground truth, as we currently lack a way to have Lossless-compressed textures be imported as RG8 (Normal Map import option isn't available).
The final result (albedo with normal map) looks very close either way.
Testing project:
APKs for quick testing on Android:
Desktop
| Before | After (this PR) |
|---|---|
 |
 |
Mobile
Tested on Samsung Galaxy Z Fold4 (Adreno 730).
| Before | After (this PR) |
|---|---|
 |
 |
| } else { | ||
| // No supported VRAM compression formats, decompress. | ||
| basisu_format = basist::transcoder_texture_format::cTFRGBA32; | ||
| image_format = Image::FORMAT_RGBA8; |
There was a problem hiding this comment.
Couldn't Image::FORMAT_RG8 or Image::FORMAT_LA8 be used here?
There was a problem hiding this comment.
BasisU doesn't allow directly decompressing textures to R8/RG8, so they have to be converted after decompression. This increases the loading time slightly, though I think the tradeoff is worth it since less VRAM is wasted.
| } else { | ||
| // No supported VRAM compression formats, decompress. | ||
| basisu_format = basist::transcoder_texture_format::cTFRGBA32; | ||
| image_format = Image::FORMAT_RGBA8; |
There was a problem hiding this comment.
Couldn't Image::FORMAT_R8 be used here?
BlueCube3310
force-pushed
the
basisu-rgtc-etc2-rg
branch
from
01406ff to
838a67e
Compare
BlueCube3310
force-pushed
the
basisu-rgtc-etc2-rg
branch
from
838a67e to
337d80d
Compare
|
Thanks! |
Depends on #89426
Changes BasisUniversal's destination format for normal maps from
(DXT5/ETC2)_RA-As-RGtoRGTC_RG/ETC2_RG11, which results in a slight quality gain.Also adds support for encoding R-channel only images and decoding them as
RGTC_R/ETC2_R11.This needs testing on mobile devices, but I suspect the difference in quality will be most significant there.
MRP:
basisurgtctest.zip